Split up internet DNS tests to avoid timeout problem #2802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason, the CI win2012 machine was timing out on the internet test-dns file. Split out ipv4 and ipv6 specific tests to separate files so tests do not time out. (Each file is given a 60 second timeout on CI. Tests within a file are run in sequence.)
mscdex
added
dns
|
bump /cc @nodejs/collaborators |
|
Why does splitting the tests into separate files fix the timeout issue? |
|
@silverwind It fixes it because the timeout that's blowing up isn't for any individual test in the file. It's the 60 second timeout for each test file imposed by the Python test runner for the file as a whole. |
|
Ah, right. LGTM if this is just copy/paste split up. |
| running = false, | ||
| queue = []; | ||
|
|
||
| function TEST(f) { |
There was a problem hiding this comment.
Future pr: export these things to common if they are re-usable.
There was a problem hiding this comment.
As far as TEST() goes, I was torn between "move this into the common.js" vs. "extract each test into its own file and get rid of TEST() entirely". So I left it alone for now.
Trott
added a commit
that referenced
this pull request
Sep 12, 2015
For whatever reason, the CI win2012 machine was timing out on the internet test-dns file. Split out ipv4 and ipv6 specific tests to separate files so tests do not time out. (Each file is given a 60 second timeout on CI. Tests within a file are run in sequence.) PR-URL: #2802 Fixes: #2468 Reviewed-By: Roman Reiss <me@silverwind.io>
|
Landed in a787f72 |
Trott
added a commit
that referenced
this pull request
Sep 15, 2015
For whatever reason, the CI win2012 machine was timing out on the internet test-dns file. Split out ipv4 and ipv6 specific tests to separate files so tests do not time out. (Each file is given a 60 second timeout on CI. Tests within a file are run in sequence.) PR-URL: #2802 Fixes: #2468 Reviewed-By: Roman Reiss <me@silverwind.io>
Trott
added a commit
that referenced
this pull request
Sep 15, 2015
For whatever reason, the CI win2012 machine was timing out on the internet test-dns file. Split out ipv4 and ipv6 specific tests to separate files so tests do not time out. (Each file is given a 60 second timeout on CI. Tests within a file are run in sequence.) PR-URL: #2802 Fixes: #2468 Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the CI setup, the Win2012 server times out sometimes on
test/internet/test-dns.js. This PR follows on the changes in #2785 (which will land soon) and splits that file into three files which avoids the timeout.CI doesn't (yet) run tests in
test/internetbut I altered thevcbuild.batin a branch so that it would. Results for this change are at https://ci.nodejs.org/job/node-test-commit-windows/604/.