Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: guard test-doc recipe with node_use_openssl #28199

Closed
wants to merge 1 commit into from

Commits on Jun 13, 2019

  1. build: guard test-doc recipe with node_use_openssl

    Currently, when configuring --without-ssl the test-doc target fails with
    the following error:
    /node/test/common/index.js:707
    const crashOnUnhandledRejection = (err) => { throw err; };
                                                 ^
    
    Error [ERR_NO_CRYPTO]:
    Node.js is not compiled with OpenSSL crypto support
        at Object.assertCrypto (internal/util.js:97:11)
        at https.js:26:26
        at NativeModule.compile (internal/bootstrap/loaders.js:300:5)
        ...
        at /node/tools/doc/versions.js:7:19
        at new Promise (<anonymous>)
        at getUrl (/node/tools/doc/versions.js:6:10)
    Command: out/Release/node /node/test/doctool/test-doctool-html.js
    [00:02|% 100|+   3|-   1]: Done
    make: *** [test-doc] Error 1
    
    This commit guards the test-doc recipe to not run if node was
    configured without crypto support.
    danbev committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    bb17e5a View commit details
    Browse the repository at this point in the history