inspector: added --inspect-publish-uid-ipc-path argument #28235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument takes the IPC path as an argument when it is passed, the inspector web socket server will send its full web socket url to IPC server with the given path at the start. This flag is required to solve inspector web socket url discovery the problem for child processes. Only one discovery option is available right now; it is searching for ws:// URLs in stderr of node process. This approach does not work when the parent process ignores the stderr of the child process, e.g. update-notifier uses this technique. Discussion about using files instead can be found here: nodejs/diagnostics#298
|
Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot
added
c++
|
@nodejs/inspector PTAL. @ak239 seems like this needs a rebase. |
|
I think that I managed to solve this problem in user land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument takes the IPC path as an argument when it is passed,
the inspector web socket server will send its full web socket url
to IPC server with the given path at the start.
This flag is required to solve inspector web socket url discovery
the problem for child processes.
Only one discovery option is available right now; it is searching
for ws:// URLs in stderr of node process. This approach does not
work when the parent process ignores the stderr of the child process,
e.g. update-notifier uses this technique.
Discussion about using files instead can be found here:
nodejs/diagnostics#298
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes