Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Fixing typos #2852

Closed
wants to merge 2 commits into from
Closed

doc: Fixing typos #2852

wants to merge 2 commits into from

Conversation

IonicaBizau
Copy link
Contributor

  • Fixed typo: "insallation" -> "installation"
  • Added an "if" in a sentence where it was needed for clarity.

IonicaBizau
IonicaBizau reviewed Sep 14, 2015
View reviewed changes
README.md
@@ -405,7 +405,7 @@ gpg --keyserver pool.sks-keyservers.net --recv-keys DD8F2338BAE7501E3DD5AC78C273
```

See the section above on [Verifying Binaries](#verifying-binaries) for
details on what to do with these keys to verify a downloaded file is official.
details on what to do with these keys to verify if a downloaded file is official.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this should be here or not, but I think it's better with if. 😄 What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if is totally fine and an improvement. FWIW, I'd prefer that.

@brendanashworth brendanashworth added the doc Issues and PRs related to the documentations. label Sep 14, 2015
@targos
Copy link
Member

targos commented Sep 14, 2015

LGTM.
Can you please change the commit subject to something like doc: fix typos in README (no capital and imperative form of the verb) ?

@IonicaBizau
Copy link
Contributor Author

@targos Sure, will edit it and force push. 👍

@IonicaBizau
doc: fix typos in README
055c2ec 
 - Fixed typo: "insallation" -> "installation"
 - Added an "if" in a sentence where it was needed for clarity.
@IonicaBizau
Copy link
Contributor Author

@targos Pushed. 😄

@targos
Copy link
Member

targos commented Sep 14, 2015

LGTM

1 similar comment
@thefourtheye
Copy link
Contributor

LGTM

@Trott
Copy link
Member

Trott commented Sep 14, 2015

LGTM. I made one minor nit that can totally be ignored.

@IonicaBizau
Copy link
Contributor Author

@Trott I can change it if you like. Just tell me what commit message should I write. Something like doc: use "that" instead of "if" in README?

@Trott
Copy link
Member

Trott commented Sep 14, 2015

Same as your current commit message, just change "if" to "that". When the PR gets landed, all the commits will be squashed into one commit.

@IonicaBizau
doc: fix typos in README
90a64e0 
 - Fixed typo: "insallation" -> "installation"
 - Added an "that" in a sentence where it was needed for clarity.
@IonicaBizau
Copy link
Contributor Author

When the PR gets landed, all the commits will be squashed into one commit.

Ah, good to know. Pushed. 🎈

@Trott
Copy link
Member

Trott commented Sep 14, 2015

LGTM

1 similar comment
@targos
Copy link
Member

targos commented Sep 14, 2015

LGTM

@IonicaBizau
Copy link
Contributor Author

...this was my birthday gift for you, guys! Haha! 😄 🎉

@targos
Copy link
Member

targos commented Sep 14, 2015

@Trott can you land it? I'm not on a computer

@Trott
Copy link
Member

Trott commented Sep 14, 2015

Landed in 7f5d6c9. Thanks!

@Trott Trott closed this Sep 14, 2015
Trott pushed a commit that referenced this pull request Sep 14, 2015
@IonicaBizau @Trott
doc: fix typos in README
7f5d6c9 
 - Fixed typo: "insallation" -> "installation"
 - Added an "that" in a sentence where it was needed for clarity.

PR-URL: #2852
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Sep 15, 2015
@IonicaBizau @Fishrock123
doc: fix typos in README
7ee36d6 
 - Fixed typo: "insallation" -> "installation"
 - Added an "that" in a sentence where it was needed for clarity.

PR-URL: #2852
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Sep 15, 2015
Closed
7 tasks
@IonicaBizau
Copy link
Contributor Author

Glad I helped 😸

@IonicaBizau IonicaBizau deleted the typos branch September 15, 2015 05:58
rvagg pushed a commit that referenced this pull request Sep 15, 2015
@IonicaBizau @rvagg
doc: fix typos in README
9dd9c85 
 - Fixed typo: "insallation" -> "installation"
 - Added an "that" in a sentence where it was needed for clarity.

PR-URL: #2852
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@rvagg rvagg mentioned this pull request Sep 15, 2015
Merged
@rvagg rvagg mentioned this pull request Sep 22, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IonicaBizau @targos @thefourtheye @Trott @brendanashworth