src: expose MaybeInitializeContext to allow existing contexts #28544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
addaleax
reviewed
Jul 4, 2019
Splits the node.js specific tweak intialization of NewContext into a new helper MaybeInitializeContext so that embedders with existing contexts can still use them in a node Environment now that primordials are initialized and required so early.
MarshallOfSound
force-pushed
the
expose-maybe-initialize-context
branch
from
edddd5d
to
98b6cf5
Compare
joyeecheung
reviewed
Jul 5, 2019
src/node.h
Outdated
| @@ -305,6 +305,12 @@ NODE_EXTERN v8::Local<v8::Context> NewContext( | |||
| v8::Local<v8::ObjectTemplate> object_template = | |||
| v8::Local<v8::ObjectTemplate>()); | |||
|
|
|||
| // Runs Node.js-specific tweaks on an already constructed context | |||
| NODE_EXTERN v8::Local<v8::Context> MaybeInitializeContext( | |||
There was a problem hiding this comment.
For legacy reasons NewContext still need to return a Local, but for a new API I think we should return a MaybeLocal here. I would drop the word Maybe in the function name in favor of a more practical signature.
|
Ping @MarshallOfSound |
|
Sorry @BridgeAR had PTO last week 🌴 I ended up with a slightly different approach here, I realized that |
MarshallOfSound
force-pushed
the
expose-maybe-initialize-context
branch
from
9c6cacf
to
a954ce8
Compare
joyeecheung
reviewed
Jul 17, 2019
joyeecheung
reviewed
Jul 17, 2019
MarshallOfSound
force-pushed
the
expose-maybe-initialize-context
branch
from
a954ce8
to
2dcfc04
Compare
joyeecheung
approved these changes
Jul 23, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Aug 26, 2019
|
Landed in 33ae95c |
Trott
pushed a commit
that referenced
this pull request
Aug 27, 2019
Splits the node.js specific tweak intialization of NewContext into a new helper MaybeInitializeContext so that embedders with existing contexts can still use them in a Node.js Environment now that primordials are initialized and required so early. Update MaybeInitializeContext to return MaybeLocal, PR-URL: #28544 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
Splits the node.js specific tweak intialization of NewContext into a new helper MaybeInitializeContext so that embedders with existing contexts can still use them in a Node.js Environment now that primordials are initialized and required so early. Update MaybeInitializeContext to return MaybeLocal, PR-URL: #28544 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2019
Splits the node.js specific tweak intialization of NewContext into a new helper MaybeInitializeContext so that embedders with existing contexts can still use them in a Node.js Environment now that primordials are initialized and required so early. Update MaybeInitializeContext to return MaybeLocal, PR-URL: #28544 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 5, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 5, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 5, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 5, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 6, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 19, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 23, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 27, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 14, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 14, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the node.js specific tweak intialization of NewContext into a new helper MaybeInitializeContext so that embedders with existing contexts can still use them in a node Environment now that primordials are initialized and required so early.
Found this issue while upgrading Electron to node 12.4, now primordials are created in every context --> electron/node@3da36d0 we need to initialize a context the same way node does but we don't create the context so this method had to be split into two to allow folks with pre-created contexts to still use them in node Environments
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes