doc: fix nits in child_process.md #29024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
child_process
lpinca
approved these changes
Aug 6, 2019
doc/api/child_process.md
Outdated
| @@ -218,7 +218,7 @@ a `Promise` for an `Object` with `stdout` and `stderr` properties. The returned | |||
| `ChildProcess` instance is attached to the `Promise` as a `child` property. In | |||
| case of an error (including any error resulting in an exit code other than 0), a | |||
| rejected promise is returned, with the same `error` object given in the | |||
| callback, but with an additional two properties `stdout` and `stderr`. | |||
| callback, but with additional two properties `stdout` and `stderr`. | |||
There was a problem hiding this comment.
Suggested change
| callback, but with additional two properties `stdout` and `stderr`. | |
| callback, but with two additional properties `stdout` and `stderr`. |
* Use `console.error()` for error or stderr output. * Unify comment style. * Unify link format. * Correct link URL. * Fix some typos.
jasnell
approved these changes
Aug 7, 2019
cjihrig
approved these changes
Aug 7, 2019
antsmartian
approved these changes
Aug 7, 2019
Trott
approved these changes
Aug 7, 2019
Trott
added
the
author ready
|
Landed in bf692ce |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 9, 2019
* Use `console.error()` for error or stderr output. * Unify comment style. * Unify link format. * Correct link URL. * Fix some typos. PR-URL: nodejs#29024 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
* Use `console.error()` for error or stderr output. * Unify comment style. * Unify link format. * Correct link URL. * Fix some typos. PR-URL: #29024 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesconsole.error()for error or stderr output.