stream: inline onwritedrain #29037
Closed
stream: inline onwritedrain #29037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
lpinca
approved these changes
Aug 8, 2019
ronag
force-pushed
the
stream-inline-on-write-drain
branch
from
08bb994
to
180245f
Compare
|
@nodejs/streams |
trivikr
approved these changes
Aug 9, 2019
trivikr
added
the
author ready
Trott
approved these changes
Aug 9, 2019
|
Landed in 83495e7 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 9, 2019
Inline and simplify onwritedrain. Also remove comment that seems to be outdated/invalid. PR-URL: nodejs#29037 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
Inline and simplify onwritedrain. Also remove comment that seems to be outdated/invalid. PR-URL: #29037 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor cleanup. Inline and simplify onwritedrain. Also remove comment that seems to be outdated/invalid.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes