Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: simplify UnionBytes #29116

Closed
wants to merge 1 commit into from
Closed

src: simplify UnionBytes #29116

wants to merge 1 commit into from

Commits on Aug 14, 2019

  1. src: simplify UnionBytes 

    Before this commit it was using a tagged union to store the one-byte and
two-byte pointers.

From a `sizeof(UnionBytes)` perspective that makes no difference - there
is a hole between the tag and the union - and it makes the code just a
little harder to reason about, IMO.
    @bnoordhuis
    bnoordhuis committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    8fb1ec0 View commit details
    Browse the repository at this point in the history