build: remove unused option #29173
Closed
build: remove unused option #29173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no longer a need to skip sequential/test-benchmark-napi because it no longer resides in sequential. Benchmark tests are now in their own directory.
nodejs-github-bot
added
the
build
richardlau
approved these changes
Aug 16, 2019
Trott
added
the
author ready
gengjiawen
approved these changes
Aug 17, 2019
antsmartian
approved these changes
Aug 17, 2019
cjihrig
approved these changes
Aug 17, 2019
jasnell
approved these changes
Aug 18, 2019
ZYSzys
approved these changes
Aug 18, 2019
lpinca
approved these changes
Aug 18, 2019
trivikr
approved these changes
Aug 18, 2019
|
Landed in ec16fda |
Trott
added a commit
that referenced
this pull request
Aug 18, 2019
There is no longer a need to skip sequential/test-benchmark-napi because it no longer resides in sequential. Benchmark tests are now in their own directory. PR-URL: #29173 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
There is no longer a need to skip sequential/test-benchmark-napi because it no longer resides in sequential. Benchmark tests are now in their own directory. PR-URL: #29173 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no longer a need to skip sequential/test-benchmark-napi because
it no longer resides in sequential. Benchmark tests are now in their own
directory.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes