Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: use callback to properly propagate error #29178

Closed
wants to merge 1 commit into from
Closed

net: use callback to properly propagate error #29178

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 17, 2019

The socket will be destroyed upstream through the proper error
flow.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag
net: use callback to properly propagate error
6a91ea2 
The socket will be destroyed upstream through the proper error
flow.
@nodejs-github-bot nodejs-github-bot added the net Issues and PRs related to the net subsystem. label Aug 17, 2019
@ronag ronag mentioned this pull request Aug 17, 2019
Closed
5 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25070/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25101/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25103/

@Trott
Copy link
Member

Trott commented Aug 19, 2019 •
edited
Loading

Out of extra caution....

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1968/ (queued)

@Trott
Copy link
Member

Trott commented Aug 20, 2019

Landed in cc7cec2

@Trott Trott closed this Aug 20, 2019
Trott pushed a commit that referenced this pull request Aug 20, 2019
@ronag @Trott
net: use callback to properly propagate error
cc7cec2 
The socket will be destroyed upstream through the proper error
flow.

PR-URL: #29178
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Aug 20, 2019
@ronag @targos
net: use callback to properly propagate error
17319e7 
The socket will be destroyed upstream through the proper error
flow.

PR-URL: #29178
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Aug 20, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @nodejs-github-bot @Trott @jasnell @lpinca