Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: add writev() promises version #29186

Merged
merged 2 commits into from
Aug 19, 2019
Merged

fs: add writev() promises version #29186

merged 2 commits into from
Aug 19, 2019

Commits on Aug 19, 2019

  1. fs: add writev() promises version 

    nodejs#25925 added fs.writev()
and fs.writevSync(), but did not include a Promises based
equivalent. This commit adds the missing method.

Refs: nodejs#25925
PR-URL: nodejs#29186
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    3273d0e View commit details
    Browse the repository at this point in the history

  2. fs: use consistent buffer array validation 

    This commit updates fs.writev() and fs.writevSync() to use the
same validation method as filehandle.writev().

PR-URL: nodejs#29186
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    8d100c2 View commit details
    Browse the repository at this point in the history