tools: delete v8_external_snapshot.gypi #29369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete the v8_external_snapshot target from gyp and disable the v8_use_external_startup_data option since it is never used anyway. Refs: nodejs#29363 (comment) Fixes: nodejs#28964
bnoordhuis
approved these changes
Aug 29, 2019
gengjiawen
approved these changes
Aug 30, 2019
devnexen
approved these changes
Aug 30, 2019
|
If CI passes as expected, this should be ready to land by Monday. Thanks all! |
|
@ryzokuken looks like it needs some more work |
bnoordhuis
reviewed
Aug 31, 2019
ryzokuken
force-pushed
the
fix/gh-28964
branch
from
fe4865e
to
57f6c83
Compare
|
Done! Will land after @bnoordhuis reviews. |
|
Travis failed with |
|
There's one more if-then-else clause in v8.gyp that can be simplified to just the else block. |
|
@bnoordhuis @gengjiawen Ah! Must've missed that. Taking caring of it. |
|
@bnoordhuis PTAL? I suppose this fixes everything. |
bnoordhuis
reviewed
Sep 5, 2019
bnoordhuis
approved these changes
Sep 5, 2019
ryzokuken
added a commit
that referenced
this pull request
Sep 5, 2019
Delete the v8_external_snapshot target from gyp and disable the v8_use_external_startup_data option since it is never used anyway. Refs: #29363 (comment) Fixes: #28964 PR-URL: #29369 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
|
Landed in 2882ce9 🎉 |
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Delete the v8_external_snapshot target from gyp and disable the v8_use_external_startup_data option since it is never used anyway. Refs: #29363 (comment) Fixes: #28964 PR-URL: #29369 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Merged
This was referenced Sep 25, 2019
This was referenced Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the v8_external_snapshot target from gyp and disable the
v8_use_external_startup_data option since it is never used anyway.
Refs: #29363 (comment)
Fixes: #28964
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @gengjiawen @bnoordhuis