gyp: make StringIO work in ninja.py #29414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow both Python 2 and 3 to access StringIO
nodejs-github-bot
added
build
4 tasks
targos
approved these changes
Sep 3, 2019
|
style nit: gyp uses two spaces for indentation |
|
👍 if you agree to fast-track |
|
The commit message should say that this fixes "./configure --ninja", and reference #29371 (comment) I kicked off a full CI. It has two approvals for fast-track, so can be landed once ci is green. |
sam-github
approved these changes
Sep 3, 2019
sam-github
pushed a commit
that referenced
this pull request
Sep 3, 2019
Allow both Python 2 and 3 to access StringIO. This fixes `./configure --ninja`, which was broken by #29371. See: #29371 (comment) PR-URL: #29414 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
|
Landed in 40060f4 |
cclauss
added
the
python
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Allow both Python 2 and 3 to access StringIO. This fixes `./configure --ninja`, which was broken by #29371. See: #29371 (comment) PR-URL: #29414 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Merged
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow both Python 2 and 3 to access StringIO
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes