test: unmark test-worker-prof as flaky #29511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has no longer been flaky since V8 7.5. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9333 Fixes: nodejs#26401
cjihrig
approved these changes
Sep 9, 2019
trivikr
approved these changes
Sep 9, 2019
gengjiawen
approved these changes
Sep 9, 2019
richardlau
approved these changes
Sep 10, 2019
Trott
approved these changes
Sep 10, 2019
Trott
added
the
author ready
jasnell
approved these changes
Sep 11, 2019
|
Landed in 62e8cc5 |
Trott
pushed a commit
that referenced
this pull request
Sep 12, 2019
This has no longer been flaky since V8 7.5. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9333 Fixes: #26401 PR-URL: #29511 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
This has no longer been flaky since V8 7.5. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9333 Fixes: #26401 PR-URL: #29511 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
This has no longer been flaky since V8 7.5. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9333 Fixes: #26401 PR-URL: #29511 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no longer been flaky since V8 7.5.
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9333
Fixes: #26401
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes