repl: convert var to let and const #29575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This goes along with the PR, nodejs#29535, that started to clean up the repl module. This PR replaces the instances of var with let/const.
devnexen
approved these changes
Sep 16, 2019
jasnell
approved these changes
Sep 16, 2019
gengjiawen
approved these changes
Sep 17, 2019
trivikr
added
the
author ready
trivikr
approved these changes
Sep 17, 2019
BridgeAR
approved these changes
Sep 18, 2019
Trott
pushed a commit
that referenced
this pull request
Sep 19, 2019
Refs: #29535 This PR replaces the instances of var with let/const. PR-URL: #29575 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in ac41959 |
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Refs: #29535 This PR replaces the instances of var with let/const. PR-URL: #29575 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
Refs: #29535 This PR replaces the instances of var with let/const. PR-URL: #29575 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean up the repl module. I wanted to keep them separate to keep smaller PR's and since i was already touching this module, i felt it was an appropriate time to update the
varsThis PR replaces the instances of var with let/const.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes