timers: always set _destroyed #29595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
the
timers
addaleax
approved these changes
Sep 17, 2019
BridgeAR
approved these changes
Sep 18, 2019
|
You’re probably thinking of https://github.com/nodejs/node/pull/27345/files. I’m still intending to merge. Personal things have been im the way. |
|
Yeah, that one. @apapirovski Would you be ok with this landing and then that rebasing once you have time? |
|
@Fishrock123 yup, totally! |
Required for other potential changes. This should make it so we can always just check _destroyed to check if a timer has been ended.
Fishrock123
force-pushed
the
timers-destroyed
branch
from
f51e238
to
57e80a7
Compare
jasnell
approved these changes
Sep 18, 2019
lpinca
approved these changes
Sep 18, 2019
patilharshal16
approved these changes
Sep 19, 2019
|
The lint failure was my mistake and was force-pushed out. I'll kick off CI here again. Sorry. |
|
Landed in a861b84 |
Trott
pushed a commit
that referenced
this pull request
Sep 22, 2019
Required for other potential changes. This should make it so we can always just check _destroyed to check if a timer has been ended. PR-URL: #29595 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sorry, I forgot to address this. I don't recall exactly why this wasn't just a Symbol but this property isn't particularly intended to be public. This change exists to facilitate other core functionality / cleanup. |
targos
pushed a commit
that referenced
this pull request
Sep 23, 2019
Required for other potential changes. This should make it so we can always just check _destroyed to check if a timer has been ended. PR-URL: #29595 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
Required for other potential changes. This should make it so we can always just check _destroyed to check if a timer has been ended. PR-URL: #29595 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for other potential changes.
This should make it so we can always just check _destroyed to check if a timer has been ended.
I think this was included in some other PR previously, perhaps it wasn't merged or something.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes