Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove align from tables #29668

Closed
wants to merge 1 commit into from
Closed

doc: remove align from tables #29668

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

This is obsolete. Also, in our case it doesn't seem to have any effect since the table cells have their natural width, i.e. as much as they need.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Also, note that especially for th, text-align is set to left anyway.

I'm not sure if there should be a lint rule for this.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 23, 2019
This is obsolete. Also, in our case it doesn't seem to have
any effect since the table cells have their natural width,
i.e. as much as they need.
@Trott
Copy link
Member

Trott commented Sep 26, 2019

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 26, 2019
@Trott
Copy link
Member

Trott commented Sep 27, 2019

Landed in 73f4dc8

@Trott Trott closed this Sep 27, 2019
Trott pushed a commit that referenced this pull request Sep 27, 2019
This is obsolete. Also, in our case it doesn't seem to have
any effect since the table cells have their natural width,
i.e. as much as they need.

PR-URL: #29668
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@XhmikosR XhmikosR deleted the master-xmr-align branch September 27, 2019 05:45
targos pushed a commit that referenced this pull request Oct 1, 2019
This is obsolete. Also, in our case it doesn't seem to have
any effect since the table cells have their natural width,
i.e. as much as they need.

PR-URL: #29668
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants