Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some typos inside the configure script #3016

Closed
wants to merge 1 commit into from
Closed

fix some typos inside the configure script #3016

wants to merge 1 commit into from

Conversation

pmq20
Copy link
Contributor

@pmq20 pmq20 commented Sep 23, 2015

  • reglar -> regular
  • is -> are
  • comment on the right indent level on "Need llvm_version..."

@pmq20 pmq20 force-pushed the minqi-pan-sep-23-2 branch 2 times, most recently from 85ed176 to 1df40f3 Compare September 23, 2015 04:06
@brendanashworth brendanashworth added the build Issues and PRs related to build files or the CI. label Sep 23, 2015
@targos
Copy link
Member

targos commented Sep 23, 2015

Changes LGTM.
The commit message should have "build" as subsystem

@pmq20 pmq20 changed the title configure: fix typo fix some typo inside configure script Sep 23, 2015
@pmq20 pmq20 changed the title fix some typo inside configure script fix some typos inside the configure script Sep 23, 2015
@pmq20
Copy link
Contributor Author

pmq20 commented Sep 23, 2015

changed commit message to "build" as subsystem.

@silverwind
Copy link
Contributor

LGTM

silverwind pushed a commit that referenced this pull request Sep 23, 2015
@pmq20 @silverwind
build: fix some typos inside the configure script
d0d4877 
PR-URL: #3016
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@silverwind
Copy link
Contributor

Thanks, landed in d0d4877.

@silverwind silverwind closed this Sep 23, 2015
Fishrock123 pushed a commit that referenced this pull request Sep 25, 2015
@pmq20 @Fishrock123
build: fix some typos inside the configure script
8335ec7 
PR-URL: #3016
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
This was referenced Sep 30, 2015
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmq20 @targos @silverwind @brendanashworth