fs: Add noop stub for FSWatcher.prototype.start #30160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Motivation: In a previous PR, nodejs#29905, I made this method a private method since it had no value to the user. There was discussion that maybe it should have been a runtime deprecation first, but was ultimatley decided that for this type of method, a noop stub was a better option. This Adds back in the method, but as a noop stub, while also keeping the real implementation private
nodejs-github-bot
added
the
fs
devnexen
approved these changes
Oct 29, 2019
addaleax
approved these changes
Oct 29, 2019
cjihrig
approved these changes
Oct 29, 2019
addaleax
added
the
author ready
trivikr
approved these changes
Oct 29, 2019
Trott
reviewed
Oct 29, 2019
| @@ -174,6 +174,8 @@ FSWatcher.prototype[kFSWatchStart] = function(filename, | |||
| } | |||
| }; | |||
|
|
|||
| FSWatcher.prototype.start = () => {}; | |||
There was a problem hiding this comment.
Is it worth adding a comment explaining that this is to maximize backward-compatibility for end users but this function should not be documented? Otherwise, someone else might come along later and remove it as unused or something?
There was a problem hiding this comment.
fair point and makes sense. I'll add a little comment
4 tasks
Trott
reviewed
Oct 29, 2019
Trott
reviewed
Oct 29, 2019
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
|
@Trott forgot to mention that i updated the comments with your suggestions |
addaleax
pushed a commit
that referenced
this pull request
Nov 5, 2019
* Motivation: In a previous PR, #29905, I made this method a private method since it had no value to the user. There was discussion that maybe it should have been a runtime deprecation first, but was ultimatley decided that for this type of method, a noop stub was a better option. This Adds back in the method, but as a noop stub, while also keeping the real implementation private PR-URL: #30160 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in f048105, thanks for the PR! |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
* Motivation: In a previous PR, #29905, I made this method a private method since it had no value to the user. There was discussion that maybe it should have been a runtime deprecation first, but was ultimatley decided that for this type of method, a noop stub was a better option. This Adds back in the method, but as a noop stub, while also keeping the real implementation private PR-URL: #30160 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: In a previous PR, #29905, I made this method a private
method since it had no value to the user.
There was discussion, #29989, that maybe it should have been a runtime deprecation
first, but was ultimatley decided that for this type of method, a
noop stub was a better option.
This Adds back in the method, but as a noop stub, while also keeping
the real implementation private
I wasn't sure if i should add the tests back in that were removed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes