src: fix function and variable names in comments #3039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefourtheye
added
the
c++
The `src/node.js` file is actually loaded and executed by `node::LoadEnvironment` function. The variable which has the contents is, `native_node`.
thefourtheye
force-pushed
the
fix-typos-in-comments
branch
from
a1259f7
to
952ff9c
Compare
| // This file is invoked by node::Load in src/node.cc, and responsible for | ||
| // bootstrapping the node.js core. Special caution is given to the performance | ||
| // of the startup process, so many dependencies are invoked lazily. | ||
| // This file is invoked by node::LoadEnvironment in src/node.cc, and |
There was a problem hiding this comment.
This should probably read "and is" instead of just "and."
There was a problem hiding this comment.
@mscdex Sure, I updated it.
|
LGTM |
|
Thanks for the review @bnoordhuis :-) Landed in af881ad |
thefourtheye
added a commit
that referenced
this pull request
Sep 25, 2015
The `src/node.js` file is actually loaded and executed by `node::LoadEnvironment` function. The variable which has the contents is, `native_node`. PR-URL: #3039 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
thefourtheye
added a commit
that referenced
this pull request
Sep 30, 2015
The `src/node.js` file is actually loaded and executed by `node::LoadEnvironment` function. The variable which has the contents is, `native_node`. PR-URL: #3039 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Sep 30, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
src/node.jsfile is actually loaded and executed bynode::LoadEnvironmentfunction.The variable which has the contents is,
native_node.