Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 7.9.317.23 #30560

Closed
wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Nov 20, 2019

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Nov 20, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 20, 2019

@MylesBorins MylesBorins mentioned this pull request Nov 20, 2019
@MylesBorins
Copy link
Contributor Author

Can we please fast-track this

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 20, 2019
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 20, 2019
@MylesBorins
Copy link
Contributor Author

failures on centos7 in V8 CI are these new?

https://ci.nodejs.org/job/node-test-commit-v8-linux/2646/nodes=centos7-ppcle,v8test=v8test/

/cc @nodejs/build

@addaleax
Copy link
Member

failures on centos7 in V8 CI are these new?

My understanding is that 2 failures are expected because of the Python 3 migration.

@richardlau
Copy link
Member

#30152

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 20, 2019

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

MylesBorins added a commit that referenced this pull request Nov 21, 2019
Refs: v8/v8@7.9.317.20...7.9.317.23

PR-URL: #30560
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@MylesBorins
Copy link
Contributor Author

Landed in cf1f1de

MylesBorins added a commit that referenced this pull request Nov 21, 2019
Refs: v8/v8@7.9.317.20...7.9.317.23

PR-URL: #30560
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants