Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 6.7.2 #30762

Merged
merged 1 commit into from
Dec 4, 2019
Merged

tools: update ESLint to 6.7.2 #30762

merged 1 commit into from
Dec 4, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 2, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 2, 2019
@Trott
Copy link
Member Author

Trott commented Dec 2, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4095/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 2, 2019
trivikr
trivikr approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott
tools: update ESLint to 6.7.2
12254ce 
PR-URL: nodejs#30762
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
Copy link
Member Author

Trott commented Dec 4, 2019

Landed in 12254ce

@Trott Trott merged commit 12254ce into nodejs:master Dec 4, 2019
@Trott Trott deleted the eslint-6.7.2 branch December 4, 2019 13:39
targos pushed a commit that referenced this pull request Dec 9, 2019
@Trott @targos
tools: update ESLint to 6.7.2
7b9400c 
PR-URL: #30762
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
@Trott @targos
tools: update ESLint to 6.7.2
54140a8 
PR-URL: #30762
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Trott @BethGriggs
tools: update ESLint to 6.7.2
fcecd09 
PR-URL: #30762
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @cjihrig @trivikr @nodejs-github-bot