Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix argument type of setAAD #30863

Closed
wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Dec 9, 2019

Just like most other crypto functions, setAAD accepts any view, not just Buffers.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@tniessen tniessen added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Dec 9, 2019
@mscdex
Copy link
Contributor

mscdex commented Dec 9, 2019

s/return type/argument type/ in commit message

@tniessen
Copy link
Member Author

Thanks @mscdex, fixed!

@tniessen tniessen changed the title doc: fix return type of setAAD doc: fix argument type of setAAD Dec 10, 2019
@addaleax
Copy link
Member

Landed in d776992

addaleax pushed a commit that referenced this pull request Dec 12, 2019
PR-URL: #30863
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax closed this Dec 12, 2019
MylesBorins pushed a commit that referenced this pull request Dec 13, 2019
PR-URL: #30863
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #30863
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@tniessen tniessen deleted the doc-fix-setaad-return-type branch January 23, 2020 03:46
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #30863
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants