Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unused symlink loop #31267

Closed
wants to merge 1 commit into from
Closed

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 9, 2020

This symlink loop was originally intended to be accessed from a test. Instead, a loop is created in the test itself, but this was unfortunately forgotten about. It's unused, so remove it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

👍 here if you'd like to fast track this.

This symlink loop was originally intended to be accessed from
a test. Instead, a loop is created by the test itself, but this
was unfortunately forgotten about. It's unused, so remove it.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 9, 2020
@nodejs-github-bot
Copy link
Collaborator

@sam-github
Copy link
Contributor

Thanks, @cjihrig

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 9, 2020

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2020
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 9, 2020
addaleax pushed a commit that referenced this pull request Jan 9, 2020
This symlink loop was originally intended to be accessed from
a test. Instead, a loop is created by the test itself, but this
was unfortunately forgotten about. It's unused, so remove it.

PR-URL: #31267
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax
Copy link
Member

addaleax commented Jan 9, 2020

Landed in d1d71db

@addaleax addaleax closed this Jan 9, 2020
@cjihrig cjihrig deleted the symloop branch January 10, 2020 00:43
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
This symlink loop was originally intended to be accessed from
a test. Instead, a loop is created by the test itself, but this
was unfortunately forgotten about. It's unused, so remove it.

PR-URL: #31267
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Jan 16, 2020
codebytere pushed a commit that referenced this pull request Mar 14, 2020
This symlink loop was originally intended to be accessed from
a test. Instead, a loop is created by the test itself, but this
was unfortunately forgotten about. It's unused, so remove it.

PR-URL: #31267
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants