Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix anchor for ERR_TLS_INVALID_CONTEXT #31915

Conversation

tniessen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@tniessen tniessen requested a review from Trott February 22, 2020 19:19
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Feb 22, 2020
@Trott
Copy link
Member

Trott commented Feb 22, 2020

Given that this fixes a rendering issue in the docs, I wouldn't mind fast-tracking this just to make sure it lands soon. Collaborators, 👍 here to approve fast-tracking.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 22, 2020
@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2020
tniessen added a commit that referenced this pull request Feb 23, 2020
PR-URL: #31915
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@tniessen
Copy link
Member Author

Fast-tracking approved by @Trott, @cjihrig, and @tniessen. Landed in fa1fc6b, thanks for reviewing.

@tniessen tniessen closed this Feb 23, 2020
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2020
@tniessen tniessen deleted the doc-fix-anchor-for-errtlsinvalidcontext branch February 23, 2020 02:15
codebytere pushed a commit that referenced this pull request Feb 27, 2020
PR-URL: #31915
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Feb 29, 2020
targos pushed a commit that referenced this pull request Apr 18, 2020
PR-URL: #31915
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants