Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add --with-arm-fpu option #3228

Closed
wants to merge 2 commits into from
Closed

build: add --with-arm-fpu option #3228

wants to merge 2 commits into from

Conversation

kapouer
Copy link
Contributor

@kapouer kapouer commented Oct 6, 2015

@brendanashworth brendanashworth added build Issues and PRs related to build files or the CI. arm Issues and PRs related to the ARM platform. labels Oct 7, 2015
mscdex
mscdex reviewed Oct 7, 2015
View reviewed changes
configure
@@ -606,11 +615,12 @@ def configure_arm(o):
else:
arm_float_abi = 'default'

o['variables']['arm_fpu'] = options.arm_fpu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it really make sense to make this explicit setting overridable by the configure script? It seems like if someone is passing the option explicitly, it should not be overridden. For example, what if an armv7 user would want to use vfp or vfpv2 instead of vfpv3 (e.g. for debugging or other reasons)?

@kapouer
Copy link
Contributor Author

kapouer commented Oct 7, 2015

I removed the default value of the option, set it inside the method which decides sane defaults,
but which honor the option in case it is set.

bnoordhuis
bnoordhuis reviewed Oct 7, 2015
View reviewed changes
configure
@@ -30,6 +30,7 @@ valid_os = ('win', 'mac', 'solaris', 'freebsd', 'openbsd', 'linux',
valid_arch = ('arm', 'arm64', 'ia32', 'mips', 'mipsel', 'ppc', 'ppc64', 'x32',
'x64', 'x86')
valid_arm_float_abi = ('soft', 'softfp', 'hard')
valid_arm_fpu = ('vfp', 'vfpv2', 'vfpv3', 'neon')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V8 also knows about vfpv3-d16. I don't know how common it is but might be nice to add.

@bnoordhuis
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/440/

@bnoordhuis
Copy link
Member

LGTM, I'll squash it when I land it. @mscdex LGTY?

@mscdex
Copy link
Contributor

mscdex commented Oct 7, 2015

LGTM I guess the test-stringbytes-external failure on node-test-binary-arm is not related...

bnoordhuis pushed a commit that referenced this pull request Oct 7, 2015
@kapouer @bnoordhuis
build: add --with-arm-fpu option
17665af 
Fixes: #2942
PR-URL: #3228
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
@bnoordhuis
Copy link
Member

Landed in 17665af, thanks.

@mscdex test-stringbytes-external is failure prone on underpowered machines, it allocates a lot of memory.

@bnoordhuis bnoordhuis closed this Oct 7, 2015
@jasnell jasnell mentioned this pull request Oct 8, 2015
Closed
29 tasks
jasnell pushed a commit that referenced this pull request Oct 8, 2015
@kapouer @jasnell
build: add --with-arm-fpu option
b3c5ad1 
Fixes: #2942
PR-URL: #3228
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell jasnell mentioned this pull request Oct 8, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kapouer @bnoordhuis @mscdex @jasnell @brendanashworth