Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify requireManualDestroy option #32514

Closed
wants to merge 1 commit into from
Closed

doc: clarify requireManualDestroy option #32514

wants to merge 1 commit into from

Conversation

HarshithaKP
Copy link
Member

Fixes: #32409

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Mar 27, 2020
addaleax pushed a commit that referenced this pull request Apr 2, 2020
@HarshithaKP @addaleax
doc: clarify requireManualDestroy option
7947811 
Fixes: #32409

PR-URL: #32514
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
@addaleax
Copy link
Member

addaleax commented Apr 2, 2020

Landed in 7947811

@addaleax addaleax closed this Apr 2, 2020
@puzpuzpuz puzpuzpuz mentioned this pull request Apr 3, 2020
Closed
4 tasks
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@HarshithaKP @BethGriggs
doc: clarify requireManualDestroy option
6fca565 
Fixes: #32409

PR-URL: #32514
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
@HarshithaKP @targos
doc: clarify requireManualDestroy option
34074aa 
Fixes: #32409

PR-URL: #32514
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@HarshithaKP @targos
doc: clarify requireManualDestroy option
f2235f6 
Fixes: #32409

PR-URL: #32514
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
@ronag ronag mentioned this pull request Aug 23, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@vdeturckheim vdeturckheim vdeturckheim approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing Documentation on asyncResource.emitDestroy()
6 participants
@HarshithaKP @addaleax @jasnell @lpinca @vdeturckheim @nodejs-github-bot