Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: remove unused string include http3_application #33926

Closed
wants to merge 1 commit into from
Closed

quic: remove unused string include http3_application #33926

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jun 17, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 17, 2020
@danbev danbev added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Jun 17, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31904/

richardlau
richardlau approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should be "http3_application"?

@danbev
Copy link
Contributor Author

danbev commented Jun 17, 2020

Commit message should be "http3_application"?

Ah sorry about that, I'll update shortly. Thanks!

@danbev danbev force-pushed the quic_http3_application_include branch from aebd2f5 to d346bbb Compare June 17, 2020 10:27
@danbev danbev changed the title src: remove unused string include http2_application src: remove unused string include http3_application Jun 17, 2020
jasnell
jasnell approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the quic related PRs, let's use quic: for the subsystem prefix

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 17, 2020
@jasnell
Copy link
Member

jasnell commented Jun 17, 2020

@nodejs/quic ... fast track?

@jasnell jasnell changed the title src: remove unused string include http3_application quic: remove unused string include http3_application Jun 17, 2020
@github-actions github-actions bot mentioned this pull request Jun 18, 2020
Open
18 tasks
@danbev danbev force-pushed the quic_http3_application_include branch from d346bbb to 2b70773 Compare June 18, 2020 04:05
@github-actions github-actions bot mentioned this pull request Jun 19, 2020
Open
36 tasks
jasnell pushed a commit that referenced this pull request Jun 19, 2020
@danbev @jasnell
quic: remove unused string include http3_application
88ef158 
PR-URL: #33926
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 19, 2020

Landed in 88ef158

@jasnell jasnell closed this Jun 19, 2020
@jasnell jasnell added the experimental Issues and PRs related to experimental features. label Jun 19, 2020
This was referenced Jun 20, 2020
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. experimental Issues and PRs related to experimental features. fast-track PRs that do not need to wait for 48 hours to land. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danbev @nodejs-github-bot @jasnell @addaleax @richardlau @codebytere