test: add non-ASCII character embedding test #33972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test that verifies that non-ASCII characters may be used in the source code provided to `LoadEnvironment()`.
2 tasks
addaleax
added
the
embedding
jasnell
approved these changes
Jun 19, 2020
|
Okay, fixed up the test here because whether V8 accepts |
34 tasks
1 similar comment
This was referenced Jun 21, 2020
addaleax
added
author ready
jasnell
pushed a commit
that referenced
this pull request
Jun 26, 2020
Add a test that verifies that non-ASCII characters may be used in the source code provided to `LoadEnvironment()`. PR-URL: #33972 Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in db6e6e3 |
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
Add a test that verifies that non-ASCII characters may be used in the source code provided to `LoadEnvironment()`. PR-URL: #33972 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Add a test that verifies that non-ASCII characters may be used in the source code provided to `LoadEnvironment()`. PR-URL: #33972 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added a commit
that referenced
this pull request
Sep 23, 2020
Add a test that verifies that non-ASCII characters may be used in the source code provided to `LoadEnvironment()`. PR-URL: #33972 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test that verifies that non-ASCII characters may be used
in the source code provided to
LoadEnvironment().Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes