Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win,msi: use x64 node executable when cross-compiling for arm64 #34009

Closed
wants to merge 5 commits into from
Closed

win,msi: use x64 node executable when cross-compiling for arm64 #34009

wants to merge 5 commits into from

Commits on Aug 8, 2020

  1. win,msi: download x64 node executable when cross-compiling for arm64 

    Uses x64 node executable for running .js files in arm64
cross-compilation scenarios. MSI can now be created by
running `vcbuild.bat release msi arm64`

Refs: nodejs#25998
Refs: nodejs#32582
    @dennisameling
    dennisameling committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    d60e8a9 View commit details
    Browse the repository at this point in the history

  2. doc: update windows arm64 build instructions 

    Updates the build instructions for Windows 10 ARM64, now that cross-compiling on a x64 host is possible.

Refs: nodejs#25998
Refs: nodejs#32582
    @dennisameling
    dennisameling committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    aeaa450 View commit details
    Browse the repository at this point in the history

  3. doc: fix linting in BUILDING.md

    @dennisameling
    dennisameling committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    baba312 View commit details
    Browse the repository at this point in the history

  4. win,msi: use x64 node for license2rtf (ARM64)

    @dennisameling
    dennisameling committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    21f392b View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Apply suggestions from code review 

    Co-authored-by: João Reis <reis@janeasystems.com>
    @dennisameling @joaocgreis
    dennisameling and joaocgreis committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    d9b0d27 View commit details
    Browse the repository at this point in the history