Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix drain() function for "Piping to writable streams from async iterators" #34018

Closed
wants to merge 1 commit into from
Closed

fix drain() function for "Piping to writable streams from async iterators" #34018

wants to merge 1 commit into from

Commits on Jun 22, 2020

  1. fix drain() function for "Piping to writable streams from async itera… 

    …tors"

The sample code for ["Piping to writable streams from async iterators"](https://nodejs.org/docs/latest-v14.x/api/stream.html#stream_piping_to_writable_streams_from_async_iterators) is containing an event listener leak, since it registers 2 event listeners, but don't remove them again.

The `drain()` function has been changed to remove all the listeners that have been registered within that function in any case again.
    @Kosta-Github
    Kosta-Github committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    c38d883 View commit details
    Browse the repository at this point in the history