Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12.x] deps: V8: cherry-pick 7889803e82d3 #34214

Closed
wants to merge 1 commit into from

Conversation

zjiaz
Copy link

@zjiaz zjiaz commented Jul 6, 2020

Original commit message:

[mips] Use t9 as the function call register.

on mips, we should use t9 when jump to a ExternalReference, because
the callee function will consider t9 as the function start address.

Change-Id: I56e2bf073fd24b2f3434dfd255d48264bfd0b2cd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826417
Auto-Submit: Yu Yin <xwafish@gmail.com>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63988}

Fixes: #33703
Refs: v8/v8@7889803

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v12.x v8 engine Issues and PRs related to the V8 dependency. labels Jul 6, 2020
@zjiaz
Copy link
Author

zjiaz commented Jul 7, 2020

Hi, how should I land this commit? I'm not very familiar with the workflow. Thanks!

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 7, 2020
@addaleax
Copy link
Member

addaleax commented Jul 7, 2020

@zjiaz Don’t worry, somebody will land this for you once CI has passed :)

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 7, 2020

@addaleax addaleax changed the title deps: V8: cherry-pick 7889803e82d3 [v12.x] deps: V8: cherry-pick 7889803e82d3 Jul 16, 2020
@zjiaz
Copy link
Author

zjiaz commented Aug 12, 2020

Hi, should I still just wait? Or there are something unfinished? Thanks!

Original commit message:

    [mips] Use t9 as the function call register.

    on mips, we should use t9 when jump to a ExternalReference, because
    the callee function will consider t9 as the function start address.

    Change-Id: I56e2bf073fd24b2f3434dfd255d48264bfd0b2cd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826417
    Auto-Submit: Yu Yin <xwafish@gmail.com>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63988}

Refs: v8/v8@7889803
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 18, 2020

BethGriggs pushed a commit that referenced this pull request Aug 18, 2020
Original commit message:

    [mips] Use t9 as the function call register.

    on mips, we should use t9 when jump to a ExternalReference, because
    the callee function will consider t9 as the function start address.

    Change-Id: I56e2bf073fd24b2f3434dfd255d48264bfd0b2cd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826417
    Auto-Submit: Yu Yin <xwafish@gmail.com>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63988}

Refs: v8/v8@7889803

PR-URL: #34214
Fixes: #33703
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs
Copy link
Member

Landed in e5049f2

@BethGriggs BethGriggs closed this Aug 18, 2020
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants