Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-cluster-net-listen-relative-path.js to run in / #34820

Merged
merged 7 commits into from
Aug 20, 2020

Commits on Aug 19, 2020

  1. doc: move addaleax to TSC emeritus

    PR-URL: nodejs#34809
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    addaleax committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    5acc69c View commit details
    Browse the repository at this point in the history
  2. build,win: use x64 Node when building for ARM64

    Uses x64 node executable for running .js files in arm64
    cross-compilation scenarios. MSI can now be created by
    running `vcbuild.bat release msi arm64`
    
    Refs: nodejs#25998
    Refs: nodejs#32582
    PR-URL: nodejs#34009
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: João Reis <reis@janeasystems.com>
    dennisameling authored and joaocgreis committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    03293aa View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. process: correctly parse Unicode in NODE_OPTIONS

    Fixes an issue on Windows, where Unicode in NODE_OPTIONS was not parsed
    correctly.
    
    Fixes: nodejs#34399
    
    PR-URL: nodejs#34476
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    bzoz committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    de565ad View commit details
    Browse the repository at this point in the history
  2. test: run REPL preview test regardless of terminal type

    PR-URL: nodejs#34798
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Mary Marchini <oss@mmarchini.me>
    Trott authored and mmarchini committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    6130cdd View commit details
    Browse the repository at this point in the history
  3. doc: sort references lexically

    Keep references sorted in ASCII order in module.md.
    
    PR-URL: nodejs#34848
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    Trott committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    9d81d12 View commit details
    Browse the repository at this point in the history
  4. doc: fix bulleted list punctuation in BUILDING.md

    Remove/add periods as appropriate in bulleted lists in BUILDING.md.
    
    PR-URL: nodejs#34849
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    Trott committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    9fd71a9 View commit details
    Browse the repository at this point in the history
  5. test: fix test-cluster-net-listen-relative-path.js to run in /

    test-cluster-net-listen-relative-path fails if run from the root
    directory on POSIX because the socket filename isn't quite long enough.
    Increase it by 2 so that the path length always exceeds 100 characters.
    
    PR-URL: nodejs#34820
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    Trott committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    796317f View commit details
    Browse the repository at this point in the history