tools: update gyp to b3cef02 #3487
Conversation
|
@bnoordhuis can you take a look at this one |
|
LGTM but can you list the significant changes in the commit log? |
|
I'm surprised at CI on MacOSX working fine. Is the floating patch of 58e914f no longer needed? |
|
That is still needed. I left the code in there. |
|
@iwuzhere Could you make an another commit for changing xcode_emulation.py from the original one? We would lost to find what floating patch was applied with git log. |
|
@iwuzhere If I understand correctly what we need is a PR with 2 commits. One which brings us to be in sync with the gyp repo and then a second which applies the floating patch so that its clear that its a change from the base. |
|
@shigeki Added the commit for xcode_emulation.py |
Includes two patches for AIX. Adds support for both 32-bit and 64-bit files[0] and uses -RPf for cp instead of -af (which is unsupported)[1] [0] https://codereview.chromium.org/1319663007 [1] https://codereview.chromium.org/1368133002 CI run here https://ci.nodejs.org/job/node-test-commit/882/ Intermittent failure that passed on rerun: https://ci.nodejs.org/job/node-test-commit-arm/958/
re-applying floating patch on top of gyp update[1] [1]58e914f
|
@shigeki @bnoordhuis good to go now ? |
|
LGTM |
Includes two patches for AIX. Adds support for both 32-bit and 64-bit files[0] and uses -RPf for cp instead of -af (which is unsupported)[1] [0] https://codereview.chromium.org/1319663007 [1] https://codereview.chromium.org/1368133002 PR-URL: #3487 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
|
CI looks good. Landed in cf0130d...be65f5f. I replaced the xcode fix with the original commit, its commit log has a bit more detail. |
Includes two patches for AIX. Adds support for both 32-bit and 64-bit files[0] and uses -RPf for cp instead of -af (which is unsupported)[1] [0] https://codereview.chromium.org/1319663007 [1] https://codereview.chromium.org/1368133002 PR-URL: #3487 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
|
In terms of a backport to 4.X it would be nice as it means less merge work for us during the rest of 4.X's lifespan. |
Includes two patches for AIX. Adds support for both 32-bit and 64-bit files[0] and uses -RPf for cp instead of -af (which is unsupported)[1] [0] https://codereview.chromium.org/1319663007 [1] https://codereview.chromium.org/1368133002 PR-URL: #3487 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Includes two patches for AIX. Adds support for both 32-bit and 64-bit files[0] and uses -RPf for cp instead of -af (which is unsupported)[1] [0] https://codereview.chromium.org/1319663007 [1] https://codereview.chromium.org/1368133002 PR-URL: #3487 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Includes two patches for AIX. Adds support for both 32-bit and 64-bit
files[0] and uses -RPf for cp instead of -af (which is unsupported)[1]
[0] https://codereview.chromium.org/1319663007
[1] https://codereview.chromium.org/1368133002
CI run here https://ci.nodejs.org/job/node-test-commit/882/
Intermittent failure that passed on rerun:
https://ci.nodejs.org/job/node-test-commit-arm/958/