Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,doc: fix wording to refer to context, not environment #34880

Closed
wants to merge 1 commit into from
Closed

src,doc: fix wording to refer to context, not environment #34880

wants to merge 1 commit into from

Conversation

wjabbour
Copy link
Contributor

  • documentation is changed or added
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 22, 2020
addaleax pushed a commit that referenced this pull request Aug 26, 2020
@wjabbour @addaleax
src,doc: fix wording to refer to context, not environment
87c43de 
PR-URL: #34880
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax
Copy link
Member

Landed in 87c43de :)

@addaleax addaleax closed this Aug 26, 2020
richardlau pushed a commit that referenced this pull request Sep 1, 2020
@wjabbour @richardlau
src,doc: fix wording to refer to context, not environment
f6a5999 
PR-URL: #34880
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@richardlau richardlau mentioned this pull request Sep 2, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@wjabbour @addaleax
src,doc: fix wording to refer to context, not environment
c2c8db6 
PR-URL: #34880
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@wjabbour @addaleax
src,doc: fix wording to refer to context, not environment
2a7c65a 
PR-URL: #34880
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wjabbour @addaleax @jasnell @nodejs-github-bot