Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix make-v8.sh #36594

Closed
wants to merge 1 commit into from
Closed

tools: fix make-v8.sh #36594

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Dec 21, 2020

V8's tools/dev/v8gen.py does not like being passed an empty string
("").

Refs: #36573 (comment)
Refs: #36099

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

V8's `tools/dev/v8gen.py` does not like being passed an empty string
(`""`).
@nodejs-github-bot nodejs-github-bot added tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Dec 21, 2020
@richardlau
Copy link
Member Author

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 21, 2020
@targos
Copy link
Member

targos commented Dec 21, 2020

Can we fast-track?

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/35028/ ✔️
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3629/ (previous got past the failures seen on master but failed tests). ✔️

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2020
@github-actions
Copy link
Contributor

Landed in 4d22dd3...21f2e88

@github-actions github-actions bot closed this Dec 22, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 22, 2020
V8's `tools/dev/v8gen.py` does not like being passed an empty string
(`""`).

PR-URL: #36594
Refs: #36099
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlau richardlau deleted the makev8 branch December 22, 2020 10:12
targos pushed a commit that referenced this pull request Dec 22, 2020
V8's `tools/dev/v8gen.py` does not like being passed an empty string
(`""`).

PR-URL: #36594
Refs: #36099
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
V8's `tools/dev/v8gen.py` does not like being passed an empty string
(`""`).

PR-URL: #36594
Refs: #36099
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants