Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix .end() error propagation #36817

Closed
wants to merge 4 commits into from
Closed

stream: fix .end() error propagation #36817

wants to merge 4 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jan 6, 2021

No description provided.

@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Jan 6, 2021
@ronag ronag requested review from mcollina and lpinca January 6, 2021 18:46
@ronag ronag mentioned this pull request Jan 6, 2021
Closed
@ronag
Copy link
Member Author

ronag commented Jan 6, 2021

@nodejs/stream

@ronag ronag requested a review from lpinca January 6, 2021 19:52
@ronag
Copy link
Member Author

ronag commented Jan 6, 2021 •
edited
Loading

@lpinca: Though I agree that the behavior is a little strange and should be discussed I'm not sure it's relevant for this PR other than we noticed it with the tests added here.

@lpinca
Copy link
Member

lpinca commented Jan 6, 2021 •
edited
Loading

I agree, I vaguely remember having already discussed it in an old PR (It was probably the PR calling all pending callbacks on error) but I may be wrong.

lpinca
lpinca approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGMT

mcollina
mcollina approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 6, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35341/

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35393/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35404/

ronag added a commit that referenced this pull request Jan 11, 2021
@ronag
stream: fix .end() error propagation
a4fce32 
PR-URL: #36817
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@ronag
Copy link
Member Author

ronag commented Jan 11, 2021

Landed in a4fce32

@ronag ronag closed this Jan 11, 2021
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@ronag @danielleadams
stream: fix .end() error propagation
4c819d6 
PR-URL: #36817
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
@lpinca lpinca mentioned this pull request Jan 23, 2021
Closed
@mcollina mcollina added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 25, 2021
@mcollina
Copy link
Member

mcollina commented Jan 25, 2021 •
edited
Loading

mark this as semver-major post-release as it broke things in v15 :(, see #37027 for more details.

cc @nodejs/tsc

@MrJithil MrJithil mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ronag @lpinca @nodejs-github-bot @mcollina