Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x backport] stream: accept iterable as a valid first argument #36831

Closed
wants to merge 1 commit into from
Closed

[v14.x backport] stream: accept iterable as a valid first argument #36831

wants to merge 1 commit into from

Conversation

voxpelli
Copy link

@voxpelli voxpelli commented Jan 7, 2021

Backport of #36479

Followed instructions in How to Backport a Pull Request to a Release Line

Motivation: Getting DefinitelyTyped/DefinitelyTyped#49868 merged for Node 14, to make the types there reflect what's been in the documentation for Node.js since Node.js 13.10

Fixes: #36437

PR-URL: #36479
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 18, 2021

@BethGriggs
Copy link
Member

Backport LGTM, but would appreciate a confirmation from @nodejs/streams that this should land in v14.x

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

BethGriggs pushed a commit that referenced this pull request Jan 19, 2021
Fixes: #36437

PR-URL: #36479
Backport-PR-URL: #36831
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs
Copy link
Member

Landed in 15a16cd (v14.x-staging). Thanks @voxpelli

@BethGriggs BethGriggs closed this Jan 19, 2021
@voxpelli voxpelli deleted the backport-36479-to-v14.x branch January 19, 2021 12:08
BethGriggs pushed a commit that referenced this pull request Jan 28, 2021
Fixes: #36437

PR-URL: #36479
Backport-PR-URL: #36831
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants