fs: runtime deprecate rmdir recursive option

[aduh95]

recursive option should be removed in a future version of Node.js in favor of fs.rm(path, { recursive: true }) to align with RMDIR(1) Unix command and most other tools:

• Deno doesn't have a rmdir API AFAICT, Deno.remove has a recursive option but is more analogous to fs.rm.
• Python doesn't have a recursive option it seems: https://docs.python.org/3/library/os.html#os.rmdir.
• C# RmDir doesn't have a recursive option either: https://docs.microsoft.com/en-us/dotnet/api/microsoft.visualbasic.filesystem.rmdir?view=net-5.0

The option was introduced in v12.10.0, and deprecated in v14.14.0 when fs.rm was added. See #35250 (comment) and #37216 for context.

[aduh95]

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2627/

[jasnell]

Needs a rebase but otherwise LGTM

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36723/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36736/

[aduh95]

Landed in 0ddd75b

[addaleax]

@jasnell @BridgeAR As the TSC members who approved this, from somebody who is actually affected by these changes: Can y’all care a bit more about our deprecation policy?

@nodejs/tsc Can we revert this?

[addaleax]

To be more specific:

• There was no reason given for why this needs to be a runtime deprecation and why a documentation deprecation is insufficient (“other platforms don’t do this” is not a reason to runtime-deprecate)
• There is no single way to get this behavior across all supported Node.js versions

[targos]

There is no single way to get this behavior across all supported Node.js versions

I remember raising this concern at some point, but I don't remember where. I'd be +1 on a revert.

[aduh95]

• There is no single way to get this behavior across all supported Node.js versions

You could do (fs.rm || fs.rmdir)(path, { recursive: true, force: true }), right?

[addaleax]

@aduh95 I guess, yes. But then why not keep fs.rmdir documentation-deprecated?

[aduh95]

IIRC, it was to nudge users to use fs.rm when available rather than fs.rmdir (documented as experimental in v12.x line), so we can remove this earlier. I agree the situation is not ideal, and I don't oppose a revert in v16.x.