deps: backport bc2e393 from v8 upstream #3792

evanlucas · 2015-11-12T16:03:20Z

Original commit message:

[tools] Make gen-postmortem-metadata.py more reliable

Instead of basing matches off of whitespace, walk the
inheritance chain and include any classes that inherit
from Object.

R=machenbach@chromium.org,jkummerow@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1435643002

Cr-Commit-Position: refs/heads/master@{#31964}

This adds some missing classes to postmortem info like
JSMap and JSSet.

R=@indutny

trevnorris · 2015-11-12T18:30:45Z

LGTM

indutny · 2015-11-12T18:34:39Z

LGTM

bnoordhuis · 2015-11-13T15:13:38Z

deps/v8/tools/gen-postmortem-metadata.py

                    line);

                if (match):
-                        klass = match.group(1);
+                        klass = match.group(1).rstrip().lstrip();


I have to ask: why not just .strip()?

Looking back on it, that is what it probably should have been...

Submitted a patch for the same: https://codereview.chromium.org/1443963004

bnoordhuis · 2015-11-13T15:14:12Z

LGTM

evanlucas · 2015-11-13T15:37:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/719/

evanlucas · 2015-11-13T16:40:16Z

weird, looks like only arm and windows builds ran?

evanlucas · 2015-11-14T02:19:44Z

ok, trying CI again https://ci.nodejs.org/job/node-test-pull-request/726/

rvagg · 2015-11-14T02:22:20Z

@joaocgreis same problem as yesterday, something's up with Jenkins, perhaps it's more complicated than just a wonky freshness detection?

evanlucas · 2015-11-14T02:24:50Z

I guess I'll hold off on landing until we get it sorted out?

rvagg · 2015-11-14T02:27:07Z

Yes please @evanlucas, also @nodejs/collaborators please note that CI is not currently doing full runs, until you get a full run passing for your tests you won't have full assurance that your changes can land. The @nodejs/build team is working on resolving this but we're fighting with Jenkins on this and it's a bit like playing wac-a-mole while riding a bucking bull.

evanlucas · 2015-11-14T02:28:04Z

Cool. Thanks. Let me know if I can help in any way :]

joaocgreis · 2015-11-14T12:49:44Z

@evanlucas CI should be good again, started a run for this PR: https://ci.nodejs.org/job/node-test-pull-request/731/

Original commit message: [tools] Make gen-postmortem-metadata.py more reliable Instead of basing matches off of whitespace, walk the inheritance chain and include any classes that inherit from Object. R=machenbach@chromium.org,jkummerow@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1435643002 Cr-Commit-Position: refs/heads/master@{nodejs#31964} This adds some missing classes to postmortem info like JSMap and JSSet. PR-URL: nodejs#3792 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

evanlucas · 2015-11-14T14:12:28Z

Thanks! Landed in 70405d4

Original commit message: [tools] Make gen-postmortem-metadata.py more reliable Instead of basing matches off of whitespace, walk the inheritance chain and include any classes that inherit from Object. R=machenbach@chromium.org,jkummerow@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1435643002 Cr-Commit-Position: refs/heads/master@{#31964} This adds some missing classes to postmortem info like JSMap and JSSet. PR-URL: #3792 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Original commit message: [tools] Make gen-postmortem-metadata.py more reliable Instead of basing matches off of whitespace, walk the inheritance chain and include any classes that inherit from Object. R=machenbach@chromium.org,jkummerow@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1435643002 Cr-Commit-Position: refs/heads/master@{nodejs#31964} This adds some missing classes to postmortem info like JSMap and JSSet. PR-URL: nodejs#3792 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Original commit message: [tools] Make gen-postmortem-metadata.py more reliable Instead of basing matches off of whitespace, walk the inheritance chain and include any classes that inherit from Object. R=machenbach@chromium.org,jkummerow@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1435643002 Cr-Commit-Position: refs/heads/master@{nodejs#31964} This adds some missing classes to postmortem info like JSMap and JSSet. Ref: nodejs#3792 PR-URL: nodejs#4106 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>

Original commit message: [tools] Make gen-postmortem-metadata.py more reliable Instead of basing matches off of whitespace, walk the inheritance chain and include any classes that inherit from Object. R=machenbach@chromium.org,jkummerow@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1435643002 Cr-Commit-Position: refs/heads/master@{#31964} This adds some missing classes to postmortem info like JSMap and JSSet. Ref: #3792 PR-URL: #4106 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>

MylesBorins · 2016-03-10T20:50:58Z

I'm going to add LTS watch to this and backport it when we do the next batch

@nodejs/collaborators last chance to veto

jasnell · 2016-03-11T00:42:16Z

@nodejs/lts

rvagg · 2016-03-14T01:45:30Z

looks OK to me for LTS I think, would love input from @nodejs/post-mortem wrt v4 support for this and how much it actually matters.

MylesBorins · 2016-03-17T17:23:46Z

perhaps @mhdawson has some thoughts

davepacheco · 2016-03-22T16:21:27Z

What's the question with respect to postmortem?

Original commit message: [tools] Make gen-postmortem-metadata.py more reliable Instead of basing matches off of whitespace, walk the inheritance chain and include any classes that inherit from Object. R=machenbach@chromium.org,jkummerow@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1435643002 Cr-Commit-Position: refs/heads/master@{nodejs#31964} This adds some missing classes to postmortem info like JSMap and JSSet. Ref: nodejs#3792 PR-URL: nodejs#4106 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>

MylesBorins · 2016-04-16T18:19:32Z

@davepacheco if this should be backported to v4

davepacheco · 2016-04-18T20:57:35Z

I'm not aware of postmortem tools that use JSMap or JSSet. If those are the only affected classes, I don't think this would matter. But then, I don't know how anybody would have noticed in the first place, so maybe something does use these? Or maybe there's some other metadata that's affected?

(Edited to clarify I was talking about JSMap, not Map.)

mhdawson · 2016-04-18T21:57:36Z

@thealphanerd the IBM tools don't currently use that port mortem data so not needed from that perspective. I know that @yunong does use the mdb port mortem tools and mentioned above that he'd like this to be landed so maybe he can comment on the need to backport.

evanlucas · 2016-04-18T21:59:32Z

I noticed it when using llnode.

MylesBorins · 2016-04-18T22:02:57Z

ping @indutny re: llnode

indutny · 2016-04-19T15:10:17Z

llnode doesn't really have support for this, at least not yet. +0 from me

MylesBorins · 2016-05-17T22:30:01Z

@nodejs/collaborators does anyone have an interest in this being backported?

indutny · 2016-05-17T23:08:34Z

Not me.

jasnell · 2016-05-17T23:21:38Z

hmm.. I'm +0 on it I think.

Original commit message: [tools] Make gen-postmortem-metadata.py more reliable Instead of basing matches off of whitespace, walk the inheritance chain and include any classes that inherit from Object. R=machenbach@chromium.org,jkummerow@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1435643002 Cr-Commit-Position: refs/heads/master@{#31964} This adds some missing classes to postmortem info like JSMap and JSSet. PR-URL: #3792 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins · 2016-06-01T21:58:09Z

I've gone ahead and landed this on staging. If anyone has any objections please feel free to make them here or on the proposal issue that will be incoming tomorrow

Original commit message: [tools] Make gen-postmortem-metadata.py more reliable Instead of basing matches off of whitespace, walk the inheritance chain and include any classes that inherit from Object. R=machenbach@chromium.org,jkummerow@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1435643002 Cr-Commit-Position: refs/heads/master@{#31964} This adds some missing classes to postmortem info like JSMap and JSSet. PR-URL: #3792 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This LTS release comes with 89 commits. This includes 46 commits that are docs related, 11 commits that are test related, 8 commits that are build related, and 4 commits that are benchmark related. Notable Changes: - debugger: - All properties of an array (aside from length) can now be printed in the repl (cjihrig) #6448 - npm: - Upgrade npm to 2.15.8 (Rebecca Turner) #7412 - stream: - Fix for a bug that became more prevalent with the stream changes that landed in v4.4.5. (Anna Henningsen) #7160 - V8: - Fix for a bug in crankshaft that was causing crashes on arm64 (Myles Borins) #7442 - Add missing classes to postmortem info such as JSMap and JSSet (evan.lucas) #3792

Original commit message: [tools] Make gen-postmortem-metadata.py more reliable Instead of basing matches off of whitespace, walk the inheritance chain and include any classes that inherit from Object. R=machenbach@chromium.org,jkummerow@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1435643002 Cr-Commit-Position: refs/heads/master@{#31964} This adds some missing classes to postmortem info like JSMap and JSSet. PR-URL: nodejs/node#3792 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

jasnell added the v8 engine Issues and PRs related to the V8 dependency. label Nov 12, 2015

indutny added land-on-v5.x post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. labels Nov 12, 2015

bnoordhuis reviewed Nov 13, 2015
View reviewed changes

evanlucas force-pushed the backport branch from 20954be to 70405d4 Compare November 14, 2015 14:12

evanlucas closed this Nov 14, 2015

evanlucas deleted the backport branch November 14, 2015 14:12

evanlucas merged commit 70405d4 into nodejs:master Nov 14, 2015

targos added v8-backport-to-4.7 labels Nov 18, 2015

MylesBorins added the lts-watch-v4.x label Mar 10, 2016

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Jun 14, 2016

MylesBorins mentioned this pull request Jun 24, 2016

v4.4.7 proposal #7395

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: backport bc2e393 from v8 upstream #3792

deps: backport bc2e393 from v8 upstream #3792

evanlucas commented Nov 12, 2015

trevnorris commented Nov 12, 2015

indutny commented Nov 12, 2015

bnoordhuis Nov 13, 2015

evanlucas Nov 13, 2015

thefourtheye Nov 14, 2015

bnoordhuis commented Nov 13, 2015

evanlucas commented Nov 13, 2015

evanlucas commented Nov 13, 2015

evanlucas commented Nov 14, 2015

rvagg commented Nov 14, 2015

evanlucas commented Nov 14, 2015

rvagg commented Nov 14, 2015

evanlucas commented Nov 14, 2015

joaocgreis commented Nov 14, 2015

evanlucas commented Nov 14, 2015

MylesBorins commented Mar 10, 2016

jasnell commented Mar 11, 2016

rvagg commented Mar 14, 2016

MylesBorins commented Mar 17, 2016

davepacheco commented Mar 22, 2016

MylesBorins commented Apr 16, 2016

davepacheco commented Apr 18, 2016 •

edited

Loading

mhdawson commented Apr 18, 2016

evanlucas commented Apr 18, 2016

MylesBorins commented Apr 18, 2016

indutny commented Apr 19, 2016

MylesBorins commented May 17, 2016

indutny commented May 17, 2016

jasnell commented May 17, 2016

MylesBorins commented Jun 1, 2016

deps: backport bc2e393 from v8 upstream #3792

deps: backport bc2e393 from v8 upstream #3792

Conversation

evanlucas commented Nov 12, 2015

trevnorris commented Nov 12, 2015

indutny commented Nov 12, 2015

bnoordhuis Nov 13, 2015

Choose a reason for hiding this comment

evanlucas Nov 13, 2015

Choose a reason for hiding this comment

thefourtheye Nov 14, 2015

Choose a reason for hiding this comment

bnoordhuis commented Nov 13, 2015

evanlucas commented Nov 13, 2015

evanlucas commented Nov 13, 2015

evanlucas commented Nov 14, 2015

rvagg commented Nov 14, 2015

evanlucas commented Nov 14, 2015

rvagg commented Nov 14, 2015

evanlucas commented Nov 14, 2015

joaocgreis commented Nov 14, 2015

evanlucas commented Nov 14, 2015

MylesBorins commented Mar 10, 2016

jasnell commented Mar 11, 2016

rvagg commented Mar 14, 2016

MylesBorins commented Mar 17, 2016

davepacheco commented Mar 22, 2016

MylesBorins commented Apr 16, 2016

davepacheco commented Apr 18, 2016 • edited Loading

mhdawson commented Apr 18, 2016

evanlucas commented Apr 18, 2016

MylesBorins commented Apr 18, 2016

indutny commented Apr 19, 2016

MylesBorins commented May 17, 2016

indutny commented May 17, 2016

jasnell commented May 17, 2016

MylesBorins commented Jun 1, 2016

davepacheco commented Apr 18, 2016 •

edited

Loading