Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-child-process-spawnsync-input #3889

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 17, 2015

Move portion of test-child-process-spawnsync-input.js (that has been
flaky on CentOS in CI) to its own file. This allows us to more easily
eliminate the cause of the flakiness without affecting other unrelated
portions of the test.

Fixes: #3863

Move portion of `test-child-process-spawnsync-input.js` (that has been
flaky on CentOS in CI) to its own file. This allows us to more easily
eliminate the cause of the flakiness without affecting other unrelated
portions of the test.

Fixes: nodejs#3863
@Trott Trott added the test Issues and PRs related to the tests. label Nov 17, 2015
@Trott
Copy link
Member Author

Trott commented Nov 17, 2015

9999 runs of the previously-flaky part of the test on CentOS 5 with no failures with this change: https://ci.nodejs.org/job/node-stress-single-test/15/nodes=centos5-32/console

@Trott
Copy link
Member Author

Trott commented Nov 17, 2015

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Nov 17, 2015
@jasnell
Copy link
Member

jasnell commented Nov 18, 2015

CI looks green with the exception of the current known failures.

@jasnell
Copy link
Member

jasnell commented Nov 18, 2015

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Nov 18, 2015

LGTM. Would you mind capitalizing the letters at the beginning of the comments when you land this?

@jasnell
Copy link
Member

jasnell commented Nov 18, 2015

Yep, I'll do that now

Trott added a commit that referenced this pull request Nov 18, 2015
Move portion of `test-child-process-spawnsync-input.js` (that has been
flaky on CentOS in CI) to its own file. This allows us to more easily
eliminate the cause of the flakiness without affecting other unrelated
portions of the test.

Fixes: #3863
PR-URL: #3889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 18, 2015

Landed in ac319c3

@jasnell jasnell closed this Nov 18, 2015
Trott added a commit that referenced this pull request Dec 1, 2015
Move portion of `test-child-process-spawnsync-input.js` (that has been
flaky on CentOS in CI) to its own file. This allows us to more easily
eliminate the cause of the flakiness without affecting other unrelated
portions of the test.

Fixes: #3863
PR-URL: #3889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit that referenced this pull request Dec 4, 2015
Move portion of `test-child-process-spawnsync-input.js` (that has been
flaky on CentOS in CI) to its own file. This allows us to more easily
eliminate the cause of the flakiness without affecting other unrelated
portions of the test.

Fixes: #3863
PR-URL: #3889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit that referenced this pull request Dec 5, 2015
Move portion of `test-child-process-spawnsync-input.js` (that has been
flaky on CentOS in CI) to its own file. This allows us to more easily
eliminate the cause of the flakiness without affecting other unrelated
portions of the test.

Fixes: #3863
PR-URL: #3889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 17, 2015
Move portion of `test-child-process-spawnsync-input.js` (that has been
flaky on CentOS in CI) to its own file. This allows us to more easily
eliminate the cause of the flakiness without affecting other unrelated
portions of the test.

Fixes: #3863
PR-URL: #3889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit that referenced this pull request Dec 23, 2015
Move portion of `test-child-process-spawnsync-input.js` (that has been
flaky on CentOS in CI) to its own file. This allows us to more easily
eliminate the cause of the flakiness without affecting other unrelated
portions of the test.

Fixes: #3863
PR-URL: #3889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the isolate-maxbuf branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants