test: http complete list of non-concat headers #3930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original test was only testing some of the headers that shouldn't be concatenated as per lib/_http_incoming.js, so now the full list is there. 'content-length` gives a parse error if you set it to a string, so the test for that header uses numbers.
mscdex
added
http
| // Test that certain response header fields do not repeat | ||
| // Test that certain response header fields do not repeat. | ||
| // 'content-length' should also be in this list, but it needs | ||
| // a numeric header, so it's tested slightly differently. |
There was a problem hiding this comment.
Should this be numeric value?
|
LGTM with one tiny comment. CI: https://ci.nodejs.org/job/node-test-pull-request/797/ |
cjihrig
pushed a commit
that referenced
this pull request
Nov 20, 2015
The original test was only testing some of the headers that shouldn't be concatenated as per lib/_http_incoming.js, so now the full list is there. 'content-length` gives a parse error if you set it to a string, so the test for that header uses numbers. PR-URL: #3930 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
CI was a little red, but not related to this. Made the comment fix when landing. Thanks! Landed in 174d4e4 |
rvagg
pushed a commit
that referenced
this pull request
Dec 5, 2015
The original test was only testing some of the headers that shouldn't be concatenated as per lib/_http_incoming.js, so now the full list is there. 'content-length` gives a parse error if you set it to a string, so the test for that header uses numbers. PR-URL: #3930 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Dec 8, 2015
Closed
|
The file this commit changes came into master as a semver major change, as such it is not part of LTS. Removing the label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original test was only testing some of the headers that shouldn't be concatenated as per
lib/_http_incoming.js, so now the full list is there and matches what's in the docs as well.content-lengthgives aParseErrorif you set it to a string, so the test for that header uses numbers.