Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix broken link hash #39426

Closed
wants to merge 1 commit into from
Closed

tools: fix broken link hash #39426

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 18, 2021

This typo results in a non-functional link in the WebCrypto docs. This
change fixes it.

@Trott
tools: fix broken link hash
744b363 
This typo results in a non-functional link in the WebCrypto docs. This
change fixes it.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jul 18, 2021
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 18, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 18, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39107/

Trott added a commit to Trott/io.js that referenced this pull request Jul 18, 2021
@Trott
tools: make internal link checker more robust
ae8c743 
The internal link checker was missing some broken links because it was
being too restrictive about the characters it accepted as part of a link
hash. Accept anything that isn't a terminating quotation mark.

Refs: nodejs#39426
Refs: nodejs#39425
Trott added a commit to Trott/io.js that referenced this pull request Jul 18, 2021
@Trott
tools: make internal link checker more robust
3702051 
The internal link checker was missing some broken links because it was
being too restrictive about the characters it accepted as part of a link
hash. Accept anything that isn't a terminating quotation mark.

Refs: nodejs#39426
Refs: nodejs#39425
@Trott Trott mentioned this pull request Jul 18, 2021
Closed
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 18, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott
Copy link
Member Author

Trott commented Jul 18, 2021

Fast-track request is so that this doesn't block #39429

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 18, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 18, 2021
@github-actions
Copy link
Contributor

Landed in a28e6bf...ffa79b3

@github-actions github-actions bot closed this Jul 18, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jul 18, 2021
@Trott @nodejs-github-bot
tools: fix broken link hash
ffa79b3 
This typo results in a non-functional link in the WebCrypto docs. This
change fixes it.

PR-URL: #39426
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Jul 19, 2021
@Trott
tools: make internal link checker more robust
cbef464 
The internal link checker was missing some broken links because it was
being too restrictive about the characters it accepted as part of a link
hash. Accept anything that isn't a terminating quotation mark.

Refs: nodejs#39426
Refs: nodejs#39425
targos pushed a commit that referenced this pull request Jul 20, 2021
@Trott @targos
tools: fix broken link hash
9b03d8f 
This typo results in a non-functional link in the WebCrypto docs. This
change fixes it.

PR-URL: #39426
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jul 20, 2021
@Trott @nodejs-github-bot
tools: make internal link checker more robust
ad5dc4c 
The internal link checker was missing some broken links because it was
being too restrictive about the characters it accepted as part of a link
hash. Accept anything that isn't a terminating quotation mark.

Refs: #39426
Refs: #39425

PR-URL: #39429
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
targos pushed a commit that referenced this pull request Jul 21, 2021
@Trott @targos
tools: make internal link checker more robust
2047072 
The internal link checker was missing some broken links because it was
being too restrictive about the characters it accepted as part of a link
hash. Accept anything that isn't a terminating quotation mark.

Refs: #39426
Refs: #39425

PR-URL: #39429
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@BethGriggs BethGriggs mentioned this pull request Jul 26, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Jul 29, 2021
@Trott @BethGriggs
tools: fix broken link hash
c6a7c3d 
This typo results in a non-functional link in the WebCrypto docs. This
change fixes it.

PR-URL: #39426
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Jul 29, 2021
@Trott @BethGriggs
tools: make internal link checker more robust
5c11a02 
The internal link checker was missing some broken links because it was
being too restrictive about the characters it accepted as part of a link
hash. Accept anything that isn't a terminating quotation mark.

Refs: #39426
Refs: #39425

PR-URL: #39429
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
@Trott @targos
tools: make internal link checker more robust
dfb77a5 
The internal link checker was missing some broken links because it was
being too restrictive about the characters it accepted as part of a link
hash. Accept anything that isn't a terminating quotation mark.

Refs: #39426
Refs: #39425

PR-URL: #39429
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@Trott Trott deleted the borked-link branch September 25, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @nodejs-github-bot @lpinca @targos @cjihrig @tniessen