Revert skip openssl 3.0 tests #39437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2ff93c8.
This commit updates error messages that have changed while these tests were disabled.
nodejs-github-bot
added
needs-ci
targos
approved these changes
Jul 19, 2021
richardlau
approved these changes
Jul 19, 2021
cjihrig
approved these changes
Jul 19, 2021
jasnell
approved these changes
Jul 19, 2021
danbev
added a commit
that referenced
this pull request
Jul 21, 2021
This commit updates error messages that have changed while these tests were disabled. PR-URL: #39437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 21, 2021
This commit updates error messages that have changed while these tests were disabled. PR-URL: #39437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 29, 2021
This commit updates error messages that have changed while these tests were disabled. PR-URL: #39437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Jul 29, 2021
This commit updates error messages that have changed while these tests were disabled. PR-URL: #39437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains two commits, one which reverts 2ff93c8, and the other updates a few OpenSSL 3.0 error messaged that have changes while these test were disabled (tested against 3.0.0-beta1+quic).