Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: close HandleWraps instead of deleting them in OnGCCollect() #39441

Closed
wants to merge 1 commit into from
Closed

src: close HandleWraps instead of deleting them in OnGCCollect() #39441

wants to merge 1 commit into from

Commits on Jul 19, 2021

  1. src: close HandleWraps instead of deleting them in OnGCCollect() 

    When all strong `BaseObjectPtr`s to a `HandleWrap` are gone, we
should not delete the `HandleWrap` outright, but instead close
it and then delete it only once the libuv close callback has been
called.

Based on the valgrind output from the issue below, this has a
good chance of fixing it.

Fixes: nodejs#39036
    @addaleax
    addaleax committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    1423974 View commit details
    Browse the repository at this point in the history