buffer: fix writeInt{B,L}E for some negative values #3994
Conversation
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes nodejs#3992 Signed-off-by: Peter A. Bigot <pab@pabigot.com>
|
/cc @trevnorris |
|
CI https://ci.nodejs.org/job/node-test-pull-request/817/ If all's good then LGTM |
|
@trevnorris From what I can see the CI build failed, but I'm at a loss as to why. At least part of it seems to be due to git failures. If you can see something that's due to my change please point it out and I'll work to fix it. |
|
Hmm, cc @nodejs/build that doesn't seem to have run all of the test jobs? |
|
Trying this again: https://ci.nodejs.org/job/node-test-pull-request/818/ |
|
Jenkins is currently messed up again. See nodejs/build#263 |
|
Jenkins is working again. New CI run: https://ci.nodejs.org/job/node-test-pull-request/842/ |
|
@orangemocha thanks for resubmitting that. AFAICT the two new failures are due to networking errors. If these aren't expected intermittent problems with the CI infrastructure and you think they could be due to my patch let me know; otherwise I'm going to claim the results are "pass" and move on. |
|
I can confirm that those failures are unrelated to this PR. |
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: #3992 PR-URL: #3994 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
|
Thanks much! Landed in bea6742. |
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: #3992 PR-URL: #3994 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: #3992 PR-URL: #3994 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: #3992 PR-URL: #3994 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: #3992 PR-URL: #3994 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: nodejs#3992 PR-URL: nodejs#3994 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
The algorithm used to convert negative values to hex generates incorrect
values when the low byte(s) of the value are zero because a carried
subtraction is applied prematurely.
Fixes #3992
Signed-off-by: Peter A. Bigot pab@pabigot.com