Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark fork regression test flaky on windows #4005

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 24, 2015

See #3635 for details and failure
examples.

Ref: #3635

@Trott
Copy link
Member Author

Trott commented Nov 24, 2015

@cjihrig
Copy link
Contributor

cjihrig commented Nov 24, 2015

LGTM

@mscdex mscdex added child_process Issues and PRs related to the child_process subsystem. windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Nov 24, 2015
Trott added a commit to Trott/io.js that referenced this pull request Nov 25, 2015
See nodejs#3635 for details and failure
examples.

Ref: nodejs#3635
PR-URL: nodejs#4005
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member Author

Trott commented Nov 25, 2015

Landed in fc47e0f

@Trott Trott closed this Nov 25, 2015
Trott added a commit that referenced this pull request Dec 1, 2015
See #3635 for details and failure
examples.

Ref: #3635
PR-URL: #4005
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott added a commit that referenced this pull request Dec 4, 2015
See #3635 for details and failure
examples.

Ref: #3635
PR-URL: #4005
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott added a commit that referenced this pull request Dec 5, 2015
See #3635 for details and failure
examples.

Ref: #3635
PR-URL: #4005
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 17, 2015
See #3635 for details and failure
examples.

Ref: #3635
PR-URL: #4005
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott added a commit that referenced this pull request Dec 23, 2015
See #3635 for details and failure
examples.

Ref: #3635
PR-URL: #4005
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
See nodejs#3635 for details and failure
examples.

Ref: nodejs#3635
PR-URL: nodejs#4005
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@refack refack mentioned this pull request Apr 27, 2017
3 tasks
refack added a commit to refack/node that referenced this pull request May 19, 2017
According to the explanation in nodejs#3635#issuecomment-157714683
And as a continuation to nodejs#5422 we also ignore EMFILE
"No more file descriptors are available,so no more files can be opened"

PR-URL: nodejs#12698
Fixes: nodejs#10286
Refs: nodejs#3635 (comment)
Refs: nodejs#5178
Refs: nodejs#5179
Refs: nodejs#4005
Refs: nodejs#5121
Refs: nodejs#5422
Refs: nodejs#12621 (comment)
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
According to the explanation in #3635#issuecomment-157714683
And as a continuation to #5422 we also ignore EMFILE
"No more file descriptors are available,so no more files can be opened"

PR-URL: #12698
Fixes: #10286
Refs: #3635 (comment)
Refs: #5178
Refs: #5179
Refs: #4005
Refs: #5121
Refs: #5422
Refs: #12621 (comment)
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott deleted the regr-flaky branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants