Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update signtool description, add url #4011

Closed
wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Nov 24, 2015

/cc @nodejs/build

suggested by @orangemocha

@mscdex mscdex added the build Issues and PRs related to build files or the CI. label Nov 25, 2015
@jbergstroem
Copy link
Member

LGTM

1 similar comment
@orangemocha
Copy link
Contributor

LGTM

rvagg added a commit that referenced this pull request Nov 30, 2015
PR-URL: #4011
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
@rvagg
Copy link
Member Author

rvagg commented Nov 30, 2015

thanks, merged @ 8a469e4

@rvagg rvagg closed this Nov 30, 2015
@rvagg rvagg deleted the sign-tool-description-and-url branch November 30, 2015 11:23
rvagg added a commit that referenced this pull request Dec 5, 2015
PR-URL: #4011
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
rvagg added a commit that referenced this pull request Dec 15, 2015
PR-URL: #4011
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
@jasnell jasnell mentioned this pull request Dec 17, 2015
rvagg added a commit that referenced this pull request Dec 17, 2015
PR-URL: #4011
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
rvagg added a commit that referenced this pull request Dec 23, 2015
PR-URL: #4011
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4011
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants