Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: skip EmptyStatements and return result with TLA #40194

Closed
wants to merge 3 commits into from

Conversation

Mesteery
Copy link
Contributor

Fixes: #39932

Finally, since I didn't get any comments under the issue, I think it's better to return anyway, it would be more consistent with something;; which return something.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Sep 23, 2021
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2021
@nodejs-github-bot
Copy link
Collaborator

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 26, 2021
@nodejs-github-bot
Copy link
Collaborator

targos pushed a commit that referenced this pull request Sep 27, 2021
Fixes: #39932

PR-URL: #40194
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos
Copy link
Member

targos commented Sep 27, 2021

Landed in 92ecd9f

@targos targos closed this Sep 27, 2021
@Mesteery Mesteery deleted the repl-tla-empty-stt branch September 27, 2021 17:55
targos pushed a commit that referenced this pull request Oct 4, 2021
Fixes: #39932

PR-URL: #40194
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

await an expression that ends with at least two semicolons returns undefined
5 participants