Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add version when diagnostics_channel APIs were added #40208

Closed
wants to merge 1 commit into from

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Sep 24, 2021

Add a yaml section to document when diagnostics_channel APIs were introduced.

Refs.: #34895

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 24, 2021
@Flarna Flarna force-pushed the doc_diag-channel_created branch 2 times, most recently from 3615a52 to d1e4736 Compare September 24, 2021 12:00
Add a yaml section to document when diagnostics_channel APIs were
introduced.
@Flarna Flarna added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 24, 2021
@Flarna Flarna requested a review from Qard September 24, 2021 12:15
@tniessen
Copy link
Member

I'm not quite sure how the module scoped <!--introduced_in=v15.1.0--> relates to this.

@Qard
Copy link
Member

Qard commented Sep 24, 2021

As far as I understand it, the introduced_in thing is for telling the version changer thing at the top of the page what version to start its range at. It doesn't seem to support features introduced partway through the life of one version and then backported partway through the life of another.

@Flarna
Copy link
Member Author

Flarna commented Sep 25, 2021

I'm not quite sure how the module scoped <!--introduced_in=v15.1.0--> relates to this.

I don't know either. it's not visible if you browse the docs. At least the version matches so seem to be fine.

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 25, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@Flarna Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2021
@github-actions
Copy link
Contributor

Landed in ae876d4...b0ef080

@github-actions github-actions bot closed this Sep 25, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 25, 2021
Add a yaml section to document when diagnostics_channel APIs were
introduced.

PR-URL: #40208
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Flarna Flarna deleted the doc_diag-channel_created branch September 25, 2021 16:17
targos pushed a commit that referenced this pull request Oct 4, 2021
Add a yaml section to document when diagnostics_channel APIs were
introduced.

PR-URL: #40208
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Mesteery Mesteery added the diagnostics_channel Issues and PRs related to diagnostics channel label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. diagnostics_channel Issues and PRs related to diagnostics channel doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants